From 649a07509122a1357433cc35187a99494e78f962 Mon Sep 17 00:00:00 2001
From: Djery-Tom <dietchidjery@gmail.com>
Date: Mon, 24 Jul 2023 12:15:53 +0100
Subject: [PATCH] fix: change error message if insuffisant fund while make
 payment

---
 app/Http/Controllers/CinetpayController.php | 4 ++++
 app/Http/Controllers/PaymentController.php  | 3 ++-
 resources/lang/en/errors.php                | 4 +++-
 resources/lang/fr/errors.php                | 3 ++-
 4 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/app/Http/Controllers/CinetpayController.php b/app/Http/Controllers/CinetpayController.php
index e532317..d72834a 100644
--- a/app/Http/Controllers/CinetpayController.php
+++ b/app/Http/Controllers/CinetpayController.php
@@ -314,6 +314,10 @@ class CinetpayController extends Controller
                             'transaction_id' => $transactionId,
                             'transaction_status' => $transaction->status
                         ]);
+                    }else{
+                        Log::error("Error Cinetpay make transfert payment");
+                        Log::error(json_encode($responseData));
+                        return $this->errorResponse(__('errors.service_unavailable_try_later'));
                     }
                 }
             }
diff --git a/app/Http/Controllers/PaymentController.php b/app/Http/Controllers/PaymentController.php
index cde59c6..13f1b78 100644
--- a/app/Http/Controllers/PaymentController.php
+++ b/app/Http/Controllers/PaymentController.php
@@ -208,7 +208,8 @@ class PaymentController extends Controller
 
             return $this->successResponse(['fees' => round($fees, 2)]);
         }else {
-            return $this->errorResponse("Aggregateur non disponible");
+            Log::error("Aggregateur non disponible");
+            return $this->errorResponse(__('errors.service_unavailable_try_later'));
         }
     }
 }
diff --git a/resources/lang/en/errors.php b/resources/lang/en/errors.php
index f0c19a6..8be879e 100755
--- a/resources/lang/en/errors.php
+++ b/resources/lang/en/errors.php
@@ -5,5 +5,7 @@ return [
     'validation_error' => 'The field :field has :validation',
     'service_unavailable' => 'Service unavailable',
     'timeout' => "The server did not receive a complete response within the timeout period. Please Try again later",
-    'network_not_taken' => "Network not taken into account"
+    'network_not_taken' => "Network not taken into account",
+    'service_unavailable_try_later' => "Service not available. please try again later"
+
 ];
diff --git a/resources/lang/fr/errors.php b/resources/lang/fr/errors.php
index 000e293..b188bfa 100755
--- a/resources/lang/fr/errors.php
+++ b/resources/lang/fr/errors.php
@@ -5,5 +5,6 @@ return [
     'validation_error' => 'Le champ :field a :validation',
     'service_unavailable' => 'Service non disponible',
     'timeout' => "Le serveur n'a pas reçu de réponse complete dans le délai imparti. Essayer plus tard",
-    'network_not_taken' => "Réseau non pris en compte"
+    'network_not_taken' => "Réseau non pris en compte",
+    'service_unavailable_try_later' => "Service non disponible. Veuillez réessayer plus tard"
 ];